Re: CD Access in 9.x and -CURRENT

On 12/30/2011 14:13, Tijl Coosemans wrote:
> On Thursday 29 December 2011 12:52:39 Claude Buisson wrote:
>> On 12/29/2011 07:41, Garrett Cooper wrote:
>>> On Wed, Dec 28, 2011 at 9:56 PM, Joseph S. Atkinson<jsa_at_freebsd.org>   wrote:
>>>> I am the maintainer of VLC, I have an outstanding PR (ports/162190) on the
>>>> issue of cdda:// access.
>>>>
>>>> I can confirm this issues, but don't know enough about driver access to fix
>>>> this myself. Doug Barton reports that cdcontrol(1) doesn't work for him, and
>>>> mplayer and audactiy also display issues running as non-root.
>>>>
>>>> Under 9.0-RC3 r228843, I get these errors on boot with no disc present in
>>>> /dev/cd0 at all.
>>>>
>>>> (pass1:ahcich2:0:0:0): ATA_IDENTIFY. ACB: ec 00 00 00 00 40 00 00 00 00 01
>>>> 00
>>>> (pass1:ahcich2:0:0:0): CAM status: ATA Status Error
>>>> (pass1:ahcich2:0:0:0): ATA status: 51 (DRDY SERV ERR), error: 04 (ABRT )
>>>> (pass1:ahcich2:0:0:0): RES: 51 04 01 14 eb 40 00 00 00 01 00
>>>>
>>>> These ports are fairly popular, but the problems may not lie exclusively
>>>> with their assumptions about FreeBSD. I am running 10.0 on another machine
>>>> specifically to test changes under src/sys/cam.
>>>>
>>>> I am worried that with the actual 9.0-RELEASE on the horizon, users will
>>>> find show stopping problems using their disc drives.
>>>
>>>       Try having users merge r228808 and r228847. If that works, then I
>>> would press re_at_ produce another RC that fixes this.
>>> Thanks,
>>> -Garrett
>>>
>>> PS This is coming from a user that was annoyed by this gap with the
>>> ATA_CAM code.
>>
>> As the submitter of ports/162190, I would firstly ask:
>>
>> Is the problem corrected by r228808 and r228847 in 10.0-CURRENT ?
>>
>> If not merging to 9.0 is useless.
>>
>> If yes I could test.
>
> There are 3 methods to access audio CDs.
> - if your drive is connected to your sound card you can use the drive's
>    built-in audio support (if present). (used by cdcontrol)
> - read raw audio data via the CAM layer. (used by cdparanoia)
> - read raw audio data via the cd(4) driver. (used by vlc, libcdio?)
>
> The first two should work. The last one has now been fixed in CURRENT,
> but programs using that method also seem to use CDRIOCSETBLOCKSIZE
> ioctl that cd doesn't implement. The driver already knows the correct
> block size though, so it seems safe to ignore the error. With the
> attached patch vlc works for me.

I just made the jump, and applied r228808 and r228847 to my sources (stable/9
dated 11/11/27 = svn r228043), and rebuilt vlc with your patch.

Conclusion: IT WORKS !! and I am currently playing an audio CD as I type this
message.

I will make a followup to ports/162190, and hope that the cam patches will be
MFCed before the release.

Thanks

CBu