Re: Fix softdep_request_cleanup difference w/ and w/o SOFTUPDATES

From: Ryan Stone <rysto32_at_gmail.com>
Date: Mon, 28 Mar 2011 11:32:12 -0400
On Mon, Mar 28, 2011 at 6:19 AM, Aleksandr Rybalko <ray_at_dlink.ua> wrote:
> Hi,
>
> I found a difference of definition softdep_request_cleanup.
> when SOFTUPDATES undefined softdep_request_cleanup take only two arguments.
>
> Patch to fix this:
>
> Index: sys/ufs/ffs/ffs_softdep.c
> ===================================================================
> --- sys/ufs/ffs/ffs_softdep.c   (revision 220095)
> +++ sys/ufs/ffs/ffs_softdep.c   (working copy)
> _at__at_ -514,9 +514,10 _at__at_
>  }
>
>  int
> -softdep_request_cleanup(fs, vp)
> +softdep_request_cleanup(fs, vp, resource)
>        struct fs *fs;
>        struct vnode *vp;
> +       int resource;
>  {
>
>        return (0);

If we need to change the definition, shouldn't we convert it to a C89
declaration at the same time?
Received on Mon Mar 28 2011 - 13:32:14 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:12 UTC