On Mon, 28 Mar 2011 11:32:12 -0400 Ryan Stone <rysto32_at_gmail.com> wrote: > On Mon, Mar 28, 2011 at 6:19 AM, Aleksandr Rybalko <ray_at_dlink.ua> > wrote: > > Hi, > > > > I found a difference of definition softdep_request_cleanup. > > when SOFTUPDATES undefined softdep_request_cleanup take only two > > arguments. > > > > Patch to fix this: > > > > Index: sys/ufs/ffs/ffs_softdep.c > > =================================================================== > > --- sys/ufs/ffs/ffs_softdep.c š (revision 220095) > > +++ sys/ufs/ffs/ffs_softdep.c š (working copy) > > _at__at_ -514,9 +514,10 _at__at_ > > š} > > > > šint > > -softdep_request_cleanup(fs, vp) > > +softdep_request_cleanup(fs, vp, resource) > > š š š šstruct fs *fs; > > š š š šstruct vnode *vp; > > + š š š int resource; > > š{ > > > > š š š šreturn (0); > > If we need to change the definition, shouldn't we convert it to a C89 > declaration at the same time? Yeah, I agree with you, but think peoples who made nice things for UFS have they own plan what to do with this. I only fix problem for building without SOFTUPDATES flag set. BTW, if someone interest I can convert all declaration of this file to C89 :) -- Aleksandr Rybalko <ray_at_ddteam.net>Received on Mon Mar 28 2011 - 16:04:06 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:12 UTC