Re: problems with em(4) since update to driver 7.2.2

Hi,

On Wed, May 4, 2011 at 5:38 PM, Jack Vogel <jfvogel_at_gmail.com> wrote:
> I have had my validation engineer busy all day, we have tried both
> a 9 kernel as well as 8.2,  using the code from HEAD, and we
> cannot reproduce this problem.
>
Actually, it can be trivially reproduced by tainting `error'. As it is
uninitialized in HEAD, it's value can be _anything_, so let's mark it
as explicitly invalid.

diff -u ./if_em.c /data/src/freebsd/em-7.2.2/src/if_em.c
--- ./if_em.c   2011-02-18 01:18:23.000000000 -0500
+++ /data/src/freebsd/em-7.2.2/src/if_em.c      2011-05-05
01:12:01.000000000 -0400
_at__at_ -3912,7 +3912,7 _at__at_
        struct  adapter         *adapter = rxr->adapter;
        struct em_buffer        *rxbuf;
        bus_dma_segment_t       seg[1];
-       int                     i, j, nsegs, error;
+       int                     i, j, nsegs, error = -1;

The error pointed out in this thread pops up in the next boot.

 - Arnaud

> The data your netstat -m shows suggests to me that what's happening
> is somehow setup of the receive ring is running more than once maybe??
>
> You asked at one point how this could go into STABLE, well, because
> not only here at Intel, but at lots of external customers this code has been
> used and tested thoroughly.
>
> I am not calling into question your problem, but until I understand what it
> is I cannot "fix" it :)
>
> The thing I am guessing right now is the culprit is the setup code, the
> reason
> is that when I ported to the igb driver I found that it did not work on our
> newer
> hardware, and so I went back to the older version of setup for igb. Now,
> even
> though I have not seen hardware fail with em, maybe there is some.
>
> To help me give me a complete pciconf -lv, and if its a namebrand system
> tell me that, including all hardware in it.
>
> If you like Olivier I can make a version of em for you that also reverts the
> setup code the way I did for igb, see if that fixes it for you?
>
> Thanks for your patience,
>
> Jack
> _______________________________________________
> freebsd-current_at_freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"
>