Re: [PATCH] Intel Sandy Bridge support for hwpmc

hi, I apply your patch on this
[root_at_capoor-daemon /usr/src]# git show
commit 4ec1d958bad5e78bcd3cc61a0da6b5a1302f8ec2
Author: kensmith <kensmith_at_FreeBSD.org>
Date:   Mon Nov 14 00:45:25 2011 +0000

    The releng/9.0 release branch has been created so convert stable/9 over
    to our standard "Politically Correct" name for the balance of the
9.0-RELEASE
    release cycle.

    Approved by:        re (implicit)

when my machine shutdown in my absence yesterday evening, I find a
kernel oops this morning,(sorry, just printf, I can not get a kernel
dump)
the kernel says it is at uncore_pcpu_fini+0x5b
I check the source, and it is at
static int
uncore_pcpu_fini(struct pmc_mdep *md, int cpu)
{
.....
	for (n = 0; n < npmc; n++)
		wrmsr(UCP_EVSEL0 + n, 0); //here
.....
here is my cpu type, and build hwpmc into kernel

Copyright (c) 1992-2011 The FreeBSD Project.
Copyright (c) 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994
        The Regents of the University of California. All rights reserved.
FreeBSD is a registered trademark of The FreeBSD Foundation.
FreeBSD 9.0-PRERELEASE #0 r+4ec1d95-dirty: Mon Nov 14 15:31:45 CST 2011
    root_at_capoor-daemon:/usr/obj/usr/src/sys/MYKERNEL amd64
CPU: Intel(R) Core(TM) i5-2300 CPU _at_ 2.80GHz (2793.02-MHz K8-class CPU)

I will try to apply this to current to see if this is reproduced.

2011/11/14 Attilio Rao <attilio_at_freebsd.org>:
> 2011/11/13 Davide Italiano <davide.italiano_at_gmail.com>:
>> On Sun, Nov 13, 2011 at 9:52 PM, Davide Italiano
>> <davide.italiano_at_gmail.com> wrote:
>>> Good evening folks.
>>> During last days I've written a patch to add sandy bridge support to
>>> hwpmc. Until now, the most recent Intel processor microarchitecture
>>> supported was Westmere.
>>> Testing is appreciated, in order to see if there's something that have
>>> to be fixed.
>>> You can find the diff here: http://davit.altervista.rg/hwpmc_sandy_bridge.diff
>>>
>>> I'd like to thanks a lot attilio_at_ that helped me to fix a bug and gnn_at_
>>> and fabient_at_ for the useful suggestions.
>>>
>>> Best
>>>
>>> Davide
>>>
>>
>> Sorry, bad link. It should be:
>> http://davit.altervista.org/hwpmc_sandy_bridge.diff
>
> I can perform some small cleanups and likely test it too.
>
> If Fabien or George can review it I'm fine with committing as long as
> all that is settled.
>
> Attilio
>
>
> --
> Peace can only be achieved by understanding - A. Einstein
> _______________________________________________
> freebsd-current_at_freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"
>