Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0

From: Craig Rodrigues <rodrigc_at_crodrigues.org>
Date: Fri, 7 Oct 2011 01:40:48 -0700
On Fri, Sep 30, 2011 at 2:12 PM, Jaakko Heinonen <jh_at_freebsd.org> wrote:
>
> Looks mostly OK to me.
>
>
> Why do you use printf() + exit() here and errx() in atacontrol? Is there
> reason to not use errx() also here?
>
>
> errx(3) adds a newline character to the output. Thus the latter '\n' is
> redundant.
>
> burncd(8) manual page date should be bumped.
>
> Thanks.
> --
> Jaakko
>

OK, based on your feedback, I will go with this patch.

-- 
Craig Rodrigues
rodrigc_at_crodrigues.org

Received on Fri Oct 07 2011 - 06:40:50 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:18 UTC