Re: ports on 10.0-CURRENT: r226027 is incorrect fix

On 8 Oct 2011 00:45, "Stanislav Sedov" <stas_at_freebsd.org> wrote:
>
> On Sat, 8 Oct 2011 02:03:37 +0300
> Mykola Dzham <i_at_levsha.me> mentioned:
>
> > Hi!
> > r226027 fix ( ... s/freebsd1\*)/SHOULDNOTMATCHANYTHING1)/ ...) is
> > incorrect: this commit breaks metaports building:
> >
> > # cd /usr/ports/print/teTeX && sudo make clean all
> > ===>  Cleaning for teTeX-3.0_5
> > ===>  License check disabled, port has not defined LICENSE
> > ===>  Found saved configuration for teTeX-3.0_2
> > ===>  Extracting for teTeX-3.0_5
> > ===>  Patching for teTeX-3.0_5
> > ===>  Configuring for teTeX-3.0_5
> > find /tmp/ports/usr/ports/print/teTeX/work/teTeX-3.0 -type f \( -name
config.libpath -o  -name config.rpath -o -name configure -o -name libtool.m4
\)  -exec sed -i '' -e 's/freebsd1\*)/SHOULDNOTMATCHANYTHING1)/'  -e
's/freebsd\[123\]\*)/SHOULDNOTMATCHANYTHING2)/' {} +
> > find: /tmp/ports/usr/ports/print/teTeX/work/teTeX-3.0: No such file or
directory
> > *** Error code 1
> >
> > Stop in /usr/ports/print/teTeX.
> > *** Error code 1
> >
> > Stop in /usr/ports/print/teTeX.
> >
> > I think this commit should be reverted. Using UNAME_r is less
destructive work around
> >
>
> Hi!
>
> I just committed the fix that checks if the ${WRKSRC} directory exists
firts.
>
>

Last I heard, portmgr explicitly disapproved of this fix-- have I missed
something??? Erwin specifically said not to do it.

Since when can anyone just commit stuff to bsd.port.mk, regardless of its
location?

This is a bad solution, please revert it or I will when I get back. We're
going to end up being asked to support it on ports_at_ otherwise.

Chris