Re: [PATCH] Fix NKPT kernel config option

From: Robert Millan <rmh_at_debian.org>
Date: Fri, 2 Sep 2011 07:23:16 +0200
2011/9/1 John Baldwin <jhb_at_freebsd.org>:
> In general we force the relevant C files to use opt_*.h includes and avoid
> nested includes of those in headers.

With this approach I can't trust that this feature will do the right
thing.  I would rather modify pmap.h by hand than run the unnecessary
risk.

> Do you know of any C files that do
> are using NKPT (or values derived from it) without including opt_pmap.h?

Many.  To obtain a full list, I suggest you put something like:

#ifdef NKPT
#warning nkpt:good
#else
#warning nkpt:bad
#endif

in pmap.h and build with "WERROR="

-- 
Robert Millan
Received on Fri Sep 02 2011 - 03:23:17 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:17 UTC