Re: svn commit: r244604 - head/usr.sbin/gssd

From: Garrett Cooper <yanegomi_at_gmail.com>
Date: Mon, 31 Dec 2012 06:58:16 -0800
On Mon, Dec 31, 2012 at 3:55 AM, Rick Macklem <rmacklem_at_uoguelph.ca> wrote:

...

> WITHOUT_KERBEROS is used other places, like telnetd. Were you aware of that?
> (I just thought it would keep it consistent, but if you think it is better
>  to use a different name, I don't care.)

Ah, no. I wasn't aware of that :). Given that something else has been
standardized around the tree, I agree that your approach of using
WITHOUT_KERBEROS is ok. I wasn't keen on the name just because it
could have simplified the code using a positive instead of a negative
predicate in the #ifdef.

I looked at the updated patch and it looks good to me :).

Thanks!
-Garrett
Received on Mon Dec 31 2012 - 13:58:24 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:33 UTC