Re: svn commit: r244604 - head/usr.sbin/gssd

From: Benjamin Kaduk <kaduk_at_MIT.EDU>
Date: Mon, 31 Dec 2012 22:08:49 -0500 (EST)
On Mon, 31 Dec 2012, Garrett Cooper wrote:

> On Mon, Dec 31, 2012 at 3:55 AM, Rick Macklem <rmacklem_at_uoguelph.ca> wrote:
>
> ...
>
>> WITHOUT_KERBEROS is used other places, like telnetd. Were you aware of that?
>> (I just thought it would keep it consistent, but if you think it is better
>>  to use a different name, I don't care.)
>
> Ah, no. I wasn't aware of that :). Given that something else has been
> standardized around the tree, I agree that your approach of using
> WITHOUT_KERBEROS is ok. I wasn't keen on the name just because it
> could have simplified the code using a positive instead of a negative
> predicate in the #ifdef.

src.conf(5) is (well, should be) authoritative for WITH_ and WITHOUT_ 
flags.

-Ben
Received on Tue Jan 01 2013 - 02:13:59 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:33 UTC