Re: [CFC/CFT] large changes in the loader(8) code

on 16/07/2012 14:14 Andrey V. Elsukov said the following:
> On 16.07.2012 15:05, Andriy Gapon wrote:
>>>> 2. I am not sure if I like the approach of moving partition tasting code into
>>>> common ZFS code (zfs.c).  On one hand, it now makes sense because the new
>>>> partition iteration code is machine-independent.  On the other hand, the reason
>>>> that I added arch_zfs_probe method was to give platforms full control over which
>>>> partitions and in what order are probed.  It seems to be important for some of them.
>>>> So, I like how your new partition interface makes it much easier to ZFS-probe
>>>> partitions, but I would prefer to have that code in arch_zfs_probe implementations
>>>> rather than in zfs_probe_dev.
>>>
>>> From the other point of view, ZFS is not a just file system and it works
>>> directly with disks and partitions. And it seems to me this code will be common
>>> for other architectures.
>>
>> Well, it seems that you haven't yet touched sparc64_zfs_probe.
> 
> Yes. It should work as before.

Well, but it's obvious that zfs_probe_dev would be attempting to do some unneeded
stuff (trying to treat partitions as disks) for that case.  To me this is a clear
indication zfs_probe_dev is not optimal for arch-independent implementation.  So I
still think that arch_zfs_probe should decide what disks and partitions to probe,
and zfs_probe_dev should only probe what it's given and not try to be any smarter.
But I've repeated myself three times already :-)

> But if Marius can suggest how to change ofw_disk.c to get disk size and sector size,
> then i will be able to break something here :)
> 
>> If you'll find that you don't have to use any ugly hacks there, then good.
>> But my impression is that it would be easier to stick to the previous approach.
> 


-- 
Andriy Gapon