Re: [CFC/CFT] large changes in the loader(8) code

On 16.07.2012 15:31, Andriy Gapon wrote:
>> Yes. It should work as before.
> 
> Well, but it's obvious that zfs_probe_dev would be attempting to do some unneeded
> stuff (trying to treat partitions as disks) for that case.  To me this is a clear
> indication zfs_probe_dev is not optimal for arch-independent implementation.  So I
> still think that arch_zfs_probe should decide what disks and partitions to probe,
> and zfs_probe_dev should only probe what it's given and not try to be any smarter.
> But I've repeated myself three times already :-)

And we will have the same - several copies of the same code in each architecture,
which i have deleted...

Sparc doesn't support DIOCGMEDIASIZE and DIOCGSECTORSIZE ioctls,
so it will not check each partition, only fd that is passed to the zfs_probe_dev.

Currently there is only one problem with ZFS tasting, that can affect users -
now we taste each disk and partition, but in the my branch ZFS tastes only disks and
partitions with type "freebsd" and "freebsd-zfs". So if you have created ZFS on top
of MBR partition with type "ntfs", then loader will be unable to detect it.

-- 
WBR, Andrey V. Elsukov