Re: [review request] usr.sbin/service - make showing files configurable

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



On 5/13/2012 6:15 PM, Doug Barton wrote:
> On 5/12/2012 8:23 PM, Bryan Drewery wrote:
>> Hi,
>>
>> I found service(8) to be inconsistent that it listed files with `service
>> -e`, but plain services with `service -l`
> 
> That behavior is by design.
> 


Could you please elaborate on the design decision?

I did of course look in base for uses of service -e and service -l,
before considering this patch. The only case I can find is in a cshrc
example, which my patch does not affect.

I had expected service -e to behave like service -l, so I could for
example, put it into a loop and check all services, using the service(8)
script itself.

    for service_name in `service -e`; do service status $service_name ||
service start $service_name; done

Of course this doesn't work as -e returns files.

    /etc/rc.d/ntpd does not exist in /etc/rc.d or the local startup
    directories (/usr/local/etc/rc.d)

This may be a poor example, but it's something I tried and was surprised
by not working.

My patch allows for the old behavior of listing the file, but improves
it so now -e -l and -r all support showing files by specifying -F, while
without, it just lists the service names.

I consider this change to be fairly trivial since -e doesn't appear to
be used anywhere currently.

> Thanks for your interest,
>
> Doug
>



Regards,
Bryan Drewery

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJPsQobAAoJEG54KsA8mwz55UcP/3m/6JnfNauEBr4/YB+fClyq
0+q6qkZIue7iXvZKxbE86Zyg4PxBMEvsteVrqZHSwSbwJmvrRj8o1aQkKS2FDgjW
0urKhNnzY2nd5cgDfE9HLSsg9gm25KWbVEcPKNhY5ru8BltRaLQ4V5XGu5XIsxYM
E2660rX71q1+GgjuU4TqKUj3m/PjNeAw37uwJTvhmWwP2EK8Aw3zOfipQAsYo4ng
ehha1gG0y6fqK44hlgr/SByiGmcN2+5OxCFQp/GFCwvVjXIUTnMN0xLs77GN1/S6
P4yMz6bE605uEaHQfbyPminfE/5t5Zisr9ctk4Vckwj+ixHetcVEa692NXGb5YwP
+WygJ6HJk7pwJnQwjFwXUSKJSA/Iy0ktXBaJDawLZWAKl2CuADq9H6fnOqdTJWF2
tgXYufvuWNzCmdfW+kOuDbzUxcUcK/GMN5y4z41Ee245h/GQ5otECD/lybeBwnZF
S90Hpc8nuctedDw5GuisQMBNNOfctdl/gRL+zmLIEDD7lzO90bz6bJlUMZt2Umzq
1vou2brIpMqmN+ci1PMSpXRIRufXSHOAPRzfPOORYZWb7t51C173YjwFt6Zkk6nt
WKXVQzM9oArfClAUilVbiqlq4PSMVh/9iCTZSsNrNWRiPjIpapxAIlXg/idgxTZA
YX6eL2j3vXWahCP0PKtP
=woA8
-----END PGP SIGNATURE-----