Re: [CFT]hwpmc update for sandybridge-e

On Mon, Oct 15, 2012 at 1:12 AM, Fabien Thomas <fabien.thomas_at_netasq.com>wrote:

>
> Le 13 oct. 2012 à 00:54, hiren panchasara a écrit :
>
> >
> >
> > On Fri, Oct 5, 2012 at 1:05 AM, Fabien Thomas <fabien.thomas_at_netasq.com>
> wrote:
> >
> > Le 5 oct. 2012 à 10:00, Fabien Thomas a écrit :
> >
> > >
> > > Le 5 oct. 2012 à 00:46, Sean Bruno a écrit :
> > >
> > >> So, I did the bear minimum and kind of hacked things together without
> > >> understanding precisely what I was doing, and I was able to massage
> the
> > >> sandybridge-e CPUs into giving me some basic functions.
> > >>
> > >> Comments or concerns before I commit this?
> > >>
> > >> http://people.freebsd.org/~sbruno/pmc_sandybridge.txt
> > >
> > > Hi Sean,
> > >
> > > The only modification required is this one
> > > http://svnweb.freebsd.org/base?view=revision&revision=237196
> > >
> > >  but davide_at_ removed it for a problem that need to be looked at.
> >
> > Looking at the doc this CPU require a full set of PMC as the list of
> event are different.
> > So this mean full manpage, full event list, …
> >
> > Doc:
> > "
> > The events in Table 19-3 apply to
> > processors with CPUID signature of DisplayFamily_DisplayModel encoding
> with the
> > following values: 06_2AH and 06_2DH. The events in Table 19-4 apply to
> processors
> > with CPUID signature 06_2AH. The events in Table 19-5 apply to
> processors with
> > CPUID signature 06_2DH.
> > "
> >
> > Required change will be the same as this commit if you want to look at
> it:
> > http://svnweb.freebsd.org/base?view=revision&revision=240164
> >
> > Hi All,
> >
> > With help of Sean, I've prepared another semi-working patch:
> > http://www.strugglingcoder.info/patches/hwpmc_sbx_1.txt
>
> Great,  i've quickly looked at the patch:
>
> I'm not sure to understand why you have removed code in your case for
> uncore.
> If you dont want to support remove it like for ivy bridge.
>

Thanks Fabien for getting back quickly. As I am not clear about uncore
support, I've removed it entirely as you suggested. I've tried to
incorporate other comments too.

New set of diffs,  pmccontrol and pmctest.py results are here:

http://www.strugglingcoder.info/patches/hwpmc_sbx_2.txt
http://www.strugglingcoder.info/patches/pmccontrol_2.txt
http://www.strugglingcoder.info/patches/pmctestpy_2.txt

I now have following event counters failing from pmctest.py script:

CYCLE_ACTIVITY.CYCLES_L2_PENDING
BACLEARS.ANY
L2_TRANS.DEMAND_DATA_RD
L2_TRANS.RF0
SQ_MISC.SPLIT_LOCK

I am not quite sure why these are failing. Will continue looking into it.

Appreciate your help,
Hiren