Re: [CFT]hwpmc update for sandybridge-e

Le 18 oct. 2012 à 03:07, hiren panchasara a écrit :

> + Sean - who got dropped from the chain somehow. 
> 
> On Wed, Oct 17, 2012 at 6:01 PM, Jim Harris <jim.harris_at_gmail.com> wrote:
> On Wed, Oct 17, 2012 at 5:55 PM, hiren panchasara
> <hiren.panchasara_at_gmail.com> wrote:
> >
> >
> > On Wed, Oct 17, 2012 at 5:12 PM, hiren panchasara
> > <hiren.panchasara_at_gmail.com> wrote:
> >>
> >>
> >>
> >> On Wed, Oct 17, 2012 at 5:00 PM, Jim Harris <jim.harris_at_gmail.com> wrote:
> >>>
> >>> On Wed, Oct 17, 2012 at 3:57 PM, hiren panchasara
> >>> <hiren.panchasara_at_gmail.com> wrote:
> >>> >
> >>> <snip>
> >>> >
> >>> >
> >>> > Thanks for the pointers Jim!
> >>> >
> >>> > It seems that everything works now with:
> >>> >
> >>> > http://www.strugglingcoder.info/patches/hwpmc_sbx_3.txt
> >
> >
> > I've also made following change in existing sandybridge (not xeon :-) )
> > mappings.
> > Let me know if that looks reasonable.
> >
> >
> > _at__at_ -2772,7 +2777,7 _at__at_
> >  __PMC_EV_ALIAS("MEM_LOAD_UOPS_LLC_HIT_RETIRED.XSNP_NONE",
> > IAP_EVENT_D2H_08H)    \
> >  __PMC_EV_ALIAS("MEM_LOAD_UOPS_LLC_HIT_RETIRED.LLC_MISS",
> > IAP_EVENT_D4H_02H)    \
> >  __PMC_EV_ALIAS("L2_TRANS.DEMAND_DATA_RD", IAP_EVENT_F0H_01H)                 \
> > -__PMC_EV_ALIAS("L2_TRANS.RF0", IAP_EVENT_F0H_02H)                            \
> > +__PMC_EV_ALIAS("L2_TRANS.RFO", IAP_EVENT_F0H_02H)                            \
> >  __PMC_EV_ALIAS("L2_TRANS.CODE_RD", IAP_EVENT_F0H_04H)                                \
> >  __PMC_EV_ALIAS("L2_TRANS.ALL_PF", IAP_EVENT_F0H_08H)                         \
> >  __PMC_EV_ALIAS("L2_TRANS.L1D_WB", IAP_EVENT_F0H_10H)                         \
> 
> This is a reasonable change, but it should be part of a separate commit.
> 
> Sure, I will separate it out.
> 
> If there are no further comments, can I ask Sean to commit on my behalf?

Can you do the man page to include both in the commit?
Except that point seems good to me.
Thanks!

Fabien

> 
> Thanks,
> Hiren