Re: CURRENT: /usr/src/sbin/newfs_nandfs/newfs_nandfs.c:89:18: error: no previous extern declaration for non-static variable

From: Ed Schouten <ed_at_80386.nl>
Date: Mon, 22 Apr 2013 00:09:10 +0200
Hi,

2013/4/21 O. Hartmann <ohartman_at_zedat.fu-berlin.de>:
> /usr/src/sbin/newfs_nandfs/newfs_nandfs.c:83:18: error: no previous
> extern declaration for non-static variable
> 'user_files' [-Werror,-Wmissing-variable-declarations]
> struct file_info user_files[] =
>                  ^

The following patch should fix this:

http://80386.nl/pub/nandfs-warns-6.txt

As of a couple of days ago, WARNS=6 requires that global variables
either have an external declaration or are marked static. As
newfs_nandfs only consists of a single C file, we can easily mark
these variables static. In this specific case it allowed the compiler
to find another peculiarity in the code, namely that the
seg_segsum_size variable is unused.

I'll commit this patch after I've done some testing.

Thanks,
--
Ed Schouten <ed_at_80386.nl>
Received on Sun Apr 21 2013 - 20:09:17 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:36 UTC