----- Original Message ----- From: "Steven Hartland" >>I had been updating/porting Steve Hartland's patches for zfs trim on mps >> for 8.3 stable. >> Trim was working fine for me before r249939. >> >> When I saw that this functionality was being added to current, I built >> world/kernel without the patches. >> Indeed, many of the commits are quite similar to the updated patch I >> worked on (patch claims most of it is 'already applied'). >> >> HOWEVER, I am not seeing a delete method detected for either of my >> Samsung 830s, which I did under my updated patch. >> It looks like scsi ata identify is not working. >> >> Are there still outstanding commits to enable this, or is something now >> a tunable/sysctl I'm missing? >> >> Previously it was working: >> kstat.zfs.misc.zio_trim.bytes: 47546368 >> kstat.zfs.misc.zio_trim.success: 2618 >> kstat.zfs.misc.zio_trim.unsupported: 0 >> kstat.zfs.misc.zio_trim.failed: 0 >> >> >> Current: >> kstat.zfs.misc.zio_trim.bytes: 0 >> kstat.zfs.misc.zio_trim.success: 0 >> kstat.zfs.misc.zio_trim.unsupported: 264 >> kstat.zfs.misc.zio_trim.failed: 0 >> kern.cam.da.3.delete_method: NONE >> kern.cam.da.3.delete_max: 0 >> kern.cam.da.4.delete_method: NONE >> kern.cam.da.4.delete_max: 0 > > I have one patch outstanding (attached) to enable ATA_TRIM support under > controllers which don't support UNMAP, I was just finalising testing on > this, which I completed this morning; I'm just waiting for approval. > > If your controller doesn't support UNMAP then this will be the reason, > however mps should support this. > > Could you confirm if previously you where seeing UNMAP as the reported > delete_method? Just tested here on an mps with 8.3 and all seems good without the final patch; disks are correctly detected as UNMAP support. I'd be interested in the output from your system after applying the patch from my previous email plus this:- --- sys/cam/scsi/scsi_da.c.orig 2013-04-27 23:33:07.413089199 +0000 +++ sys/cam/scsi/scsi_da.c 2013-04-27 23:10:40.000000000 +0000 _at__at_ -198,6 +198,7 _at__at_ }; #define dadeleteflag(softc, delete_method, enable) \ +printf("deleteflag: %s (%d) = %d\n", da_delete_method_names[delete_method], delete_method, enable); \ if (enable) { \ softc->delete_available |= (1 << delete_method); \ } else { \ Regards Steve ================================================ This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it. In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337 or return the E.mail to postmaster_at_multiplay.co.uk.Received on Sat Apr 27 2013 - 21:37:09 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:37 UTC