Re: Port problems after r253839 on HEAD

Am 09.08.2013 19:27 UTC+2, schrieb Steve Kargl:
> On Wed, Aug 07, 2013 at 07:43:33PM +0200, Baptiste Daroussin wrote:
>> On Wed, Aug 07, 2013 at 07:28:41PM +0200, Rainer Hurling wrote:
>>> After introducing r253839 on HEAD (/head/contrib/binutils/ld/ldmain.c),
>>> I recognized some wired behaviour in the ports system on my CURRENT boxes.
>>>
>>> Some of the ports do not build anymore. They print almost similar
>>> messages about an ld problem (invalid DSO for symbol 'xxx' definition),
>>> followed by the lib, which symbols are not found.
>>>
>>> With a recent 10.0-CURRENT (at least r253839) you can try this for
>>> example with the following two ports:
>>>
>> normally I had tracked down all those ports, except if you are building them
>> with nom default options,
>>
>> What that means is basically the said ports are missing some -lbla in ldflags,
>>
>> The missing ones are those listed in the line following the DSO bla
>> in nano for example the first failure means -liconv is missing.
>>
>> I afk until 24th so I can't commit any fix to the said ports.
>> There were properly building in my exp-run for the said change, meaning either
>> you build with non default options im that case the port requires a fix or
>> perhaps your ports tree is not uptodate, in particular lots of those failures
>> are fixed by the recent glib update.
> 
> 
> On a freshly rebuilt freebsd-current where I've deleted all ports
> to do a fresh build of everything I use, I see
> 
> % portmaster news/pan
> ...
>   CXXLD  pan
> /usr/bin/ld: ,: invalid DSO for symbol `libiconv_open' definition
> /usr/local/lib/libiconv.so.3: could not read symbols: Bad value
> c++: error: linker command failed with exit code 1 (use -v to see invocation)
> gmake[5]: *** [pan] Error 1
> gmake[5]: Leaving directory `/usr/ports/news/pan/work/pan-0.139/pan/gui'
> gmake[4]: *** [all-recursive] Error 1
> gmake[4]: Leaving directory `/usr/ports/news/pan/work/pan-0.139/pan'
> 
> Please, fix.
> 

If I understand bapt_at_ right, this should be all what is needed:


--- Makefile.orig	2013-06-20 17:48:12.000000000 +0200
+++ Makefile	2013-08-09 20:56:36.000000000 +0200
_at__at_ -15,7 +15,8 _at__at_
 LICENSE=	GPLv2

 LIB_DEPENDS=	pcre:${PORTSDIR}/devel/pcre \
-		gmime-2.6:${PORTSDIR}/mail/gmime26
+		gmime-2.6:${PORTSDIR}/mail/gmime26 \
+		iconv:${PORTSDIR}/converters/libiconv

 USE_BZIP2=	yes
 USE_GMAKE=	yes
_at__at_ -23,7 +24,7 _at__at_
 USE_GNOME=	intlhack
 GNU_CONFIGURE=	yes
 CPPFLAGS+=	-I${LOCALBASE}/include
-LDFLAGS+=	-L${LOCALBASE}/lib -lgnuregex
+LDFLAGS+=	-L${LOCALBASE}/lib -lgnuregex -liconv

 OPTIONS_DEFINE=	GTKSPELL GTK3
 OPTIONS_DEFAULT=GTKSPELL


HTH,
Rainer