Sergey Kandaurov wrote: > On 7 February 2013 19:42, Andriy Gapon <avg_at_freebsd.org> wrote: > > on 07/02/2013 17:36 Sergey Kandaurov said the following: > >> I tested the patch without the (*vpp != dvp) change. > >> It works well. > >> > >> It's something unrelated but when doing ls -l > >> on server (patched) and client (unpatched) sides, > >> I found some inconsistency in returned stats. > >> Or more precisely: > >> > >> NFS server > >> # stat -s /pool1/user1000/.zfs/shares/.. > >> st_dev=2050684725 st_ino=1 st_mode=040555 st_nlink=4 st_uid=0 > >> st_gid=0 > >> st_rdev=0 st_size=4 st_atime=1360251211 st_mtime=1359551493 > >> st_ctime=1359551493 st_birthtime=1359551493 st_blksize=4096 > >> st_blocks=0 st_flags=0 > >> > >> NFS client > >> # stat -s /home/user1000/.zfs/shares/.. > >> st_dev=2050684725 st_ino=7 st_mode=040555 st_nlink=2 st_uid=0 > >> st_gid=0 > >> st_rdev=1377468712 st_size=2 st_atime=1360251104 > >> st_mtime=1359551493 > >> st_ctime=1359551493 st_birthtime=-1 st_blksize=4096 st_blocks=3 > >> st_flags=0 > > > > Hmm, this looks more consistent with the earlier patch. > > Are you sure that you really tested the new kernel (on the server)? > > Sorry, I indeed booted a wrong kernel. > Now tested the really new kernel :) And it works as well. > stat -s looks consistent, thanks. > > # stat -s /home/user1000/.zfs/shares/.. > st_dev=2050684725 st_ino=1 st_mode=040555 st_nlink=4 st_uid=0 st_gid=0 > st_rdev=0 st_size=4 st_atime=1360252962 st_mtime=1359551493 > st_ctime=1359551493 st_birthtime=-1 st_blksize=4096 st_blocks=0 > st_flags=0 > Sounds good. I've attached a slightly updated patch with Andriy's suggested addition of a check for zfsvfs->z_shares_dir != 0. I can't do any commits until April, so if one of you guys is comfortable enough with the patch to commit it, you are more than welcome to do so. Thanks everyone for your help in resolving this, rick > -- > wbr, > pluknet > _______________________________________________ > freebsd-current_at_freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to > "freebsd-current-unsubscribe_at_freebsd.org"Received on Thu Feb 07 2013 - 22:41:40 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:34 UTC