Re: HEAD memsticks broken? [USB/CAM Problems?]

On 12-02-2013  8:51, Hans Petter Selasky wrote:
> On Monday 11 February 2013 23:21:05 Joel Dahl wrote:
> > On 10-02-2013  0:09, Joel Dahl wrote:
> > > On 09-02-2013 20:28, Alexander Motin wrote:
> > > > How long ago that HEAD was built? Could you get full dmesg? I don't
> > > > think that "PREVENT ALLOW MEDIUM REMOVAL" should cause device drop. "No
> > > > sense data present" also doesn't look right.
> > > 
> > > As I mentioned earlier, I've tried several HEAD snapshots.
> > 
> > Just a quick update on this: I've built quite a few releases now and
> > managed to track down the problem to somewhere between r235789 and
> > r237855. It'll probably take me another day or two before I know which
> > commit actually broke it.
> 
> Hi,
> 
> I don't see any relevant USB+UMASS patches for your issue in this interval, 
> but many patches in the SCSI/CAM area.

I finally found it. A r237477 memstick boots fine. A r237478 memstick does not.

237478 is the following commit by mav_at_:

------------------------------------------------------------------------
r237478 | mav | 2012-06-23 14:32:53 +0200 (Sat, 23 Jun 2012) | 3 lines

Add scsi_extract_sense_ccb() -- wrapper around scsi_extract_sense_len().
It allows to remove number of duplicate checks from several places.

------------------------------------------------------------------------

-- 
Joel