Re: gperf/src/options.cc -- quiesce clang warnings -Wlogical-op-parentheses

From: Sean Bruno <sean_bruno_at_yahoo.com>
Date: Fri, 25 Oct 2013 10:04:32 -0400
On Fri, 2013-10-25 at 06:38 -0400, David Chisnall wrote:
> > 
> > I'm simply trying to address the warnings that appear due to clang.
> I
> > find the builds very noisy and if there's a better way to address
> this
> > issue, I'm totally open to suggestions.
> 
> Well, for contrib code that isn't going to be around for much longer
> like gperf, the best thing to do is probably just stick
> -Wno-logical-op-parentheses in the CFLAGS.  Alternatively, adding the
> brackets as it suggested to indicate precedence is simple.
> 
> David 

Agreed.  Thank you for patience in dealing with me. :-)

I will go with my original patch that simply puts parens where they can
be picked up and leave the flow of the code alone.

http://lists.freebsd.org/pipermail/freebsd-current/2013-October/045644.html

sean

Received on Fri Oct 25 2013 - 12:10:09 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:43 UTC