Re: Apple Trackpad driver

On 01/29/14 09:49, Lundberg, Johannes wrote:
> Hi
>
> I tested the driver on a 2012 Macbook Air 11" and it works great! Good job!
>
> Is there a way to disable click-by-touch? I always preferred clicking with
> the physical button that is built in to the pad.
>

Hi,

I've added an "#if 0" around the 1 finger tap code until further. Maybe 
this feature can be tunable?

I fixed the code style, added some range checks and cleared some buffer 
issues.

When you assign a signed value to an unsigned variable, you should range 
check it, because the sign might cause an overflow when you use it later on.

int8_t x = -1;

uint32_t t = x;

"t" is now "0xffffffffU" and not "255".

Tested the code on my MacBookPro. Hope I didn't break anything. If so, 
send a patch to freebsd-usb.

http://svnweb.freebsd.org/changeset/base/261260

To get the touchpad working with Xorg, I needed to re-compile HALD with 
the attached patch.

kwm: Can you get the attached patch into ports?

Auto-loading of wsp via devd will be done later. Simply need to 
re-generate usb.conf in /etc ...

--HPS