Re: CURRENT: buildworld fails to compile: cannot find -lctf cc: error: linker command failed [libproc.so.3]

On Sun, Oct 05, 2014 at 11:18:55AM +0200, O. Hartmann wrote:
> Am Sun, 5 Oct 2014 05:36:57 +0400
> Arseny Nasokin <eirnym_at_gmail.com> schrieb:
> 
> > Mark,
> > 
> > Thank you for patch, I encounter same error and this patch works for me.
> > 
> > ✪
> > 
> > 
> > -- Eir Nym
> > 
> > On 5 October 2014 04:43, Mark Johnston <markj_at_freebsd.org> wrote:
> > 
> > > On Sat, Oct 04, 2014 at 04:41:07PM -0700, Russell L. Carter wrote:
> > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > Hash: SHA1
> > > >
> > > >
> > > >
> > > > On 10/04/14 15:58, Mark Johnston wrote:
> > > > > On Sat, Oct 4, 2014 at 3:40 PM, Mark Johnston <markj_at_freebsd.org>
> > > > > wrote:
> > > > >> On Sat, Oct 04, 2014 at 04:39:37PM -0400, Ryan Stone wrote:
> > > > >>> On Sat, Oct 4, 2014 at 2:33 PM, Mark Johnston
> > > > >>> <markj_at_freebsd.org> wrote:
> > > > >>>> On Sat, Oct 04, 2014 at 07:47:56PM +0200, O. Hartmann wrote:
> > > > >>>>> Recent sources (Revision: 272529) fail to compile:
> > > > >>>>>
> > > > >>>>> [...] cc -m32 -march=native -DCOMPAT_32BIT  -isystem
> > > > >>>>> /usr/obj/usr/src/lib32/usr/include/
> > > > >>>>> -L/usr/obj/usr/src/lib32/usr/lib32
> > > > >>>>> -B/usr/obj/usr/src/lib32/usr/lib32  -O2 -pipe -O3 -O3 -pipe
> > > > >>>>> -DYP -I/usr/obj/usr/src/lib32/usr/include/rpcsvc -std=gnu99
> > > > >>>>> -fstack-protector -Wsystem-headers -Werror
> > > > >>>>> -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int
> > > > >>>>> -Wno-unused-const-variable -Wno-tautological-compare
> > > > >>>>> -Wno-unused-value -Wno-parentheses-equality
> > > > >>>>> -Wno-unused-function -Wno-enum-conversion -Wno-switch
> > > > >>>>> -Wno-switch-enum -Wno-knr-promoted-parameter
> > > > >>>>> -Wno-parentheses -Qunused-arguments -c
> > > > >>>>> /usr/src/lib/librpcsvc/yp_passwd.c -o yp_passwd.o ---
> > > > >>>>> all_subdir_libproc --- --- libproc.so.3 ---
> > > > >>>>> /usr/obj/usr/src/tmp/usr/bin/ld: skipping incompatible
> > > > >>>>> /usr/obj/usr/src/tmp/usr/lib/libctf.so when searching for
> > > > >>>>
> > > > >>>> I'm confused by this message. Are you building with
> > > > >>>> -DNO_CLEAN? Do you have anything in make.conf or src.conf,
> > > > >>>> especially anything that's changed since libctf was rebuilt?
> > > > >>>>
> > > > >>>> You might try rebuilding libctf with
> > > > >>>>
> > > > >>>> $ cd /usr/src $ make -C cddl/lib/libctf clean all
> > > > >>>>
> > > > >>>> but I'm not sure why ld is ignoring the existing libctf.so.
> > > > >>>
> > > > >>> The failure is coming while building the lib32 compat
> > > > >>> libraries.  Are we not currently building a lib32 libctf.so?
> > > > >>
> > > > >> No, we do. One thing I've noticed is that cddl/lib is built after
> > > > >> lib/ when compiling 32-bit libs, whereas cddl/lib is built first
> > > > >> when building natively.
> > > > >
> > > > > Sorry, that's not even true. I misread a part of Makefile.inc1.
> > > > >
> > > > > I'm still not able to reproduce the problem, but it seems that the
> > > > > patch here is appropriate:
> > > > > http://people.freebsd.org/~markj/patches/libctf_prebuild.diff
> > > > >
> > > > > Oliver, could you give this a try?
> > > >
> > > > Even poudriere can't get past this one.
> > >
> > > Sorry, it was incomplete. It's been updated:
> > > http://people.freebsd.org/~markj/patches/libctf_prebuild.diff
> > > _______________________________________________
> > > freebsd-current_at_freebsd.org mailing list
> > > http://lists.freebsd.org/mailman/listinfo/freebsd-current
> > > To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"
> > >
> > _______________________________________________
> > freebsd-current_at_freebsd.org mailing list
> > http://lists.freebsd.org/mailman/listinfo/freebsd-current
> > To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"
> 
> After some minor corrections to the patch (the patched original sources seem not to match
> most recent CURRENT sources as of revision 272562), buildworld works again as expected.
> 
> Thank you very much.

Committed as r272576. Sorry for the breakage.

The patch was generated from my git tree, which didn't contain r272484,
so the patch wouldn't apply to svn cleanly. I'll be sure to check that
next time. :(

Thanks,
-Mark