Re: Early use of log() does not end up in kernel msg buffer

From: Eric Badger <eric_at_badgerio.us>
Date: Mon, 06 Apr 2015 19:36:50 -0500
On 04/06/2015 04:11 PM, Poul-Henning Kamp wrote:
> --------
> In message <2033248.Eu3RHS8lTG_at_ralph.baldwin.cx>, John Baldwin writes:
>
>> I think phk_at_ broke this back in 70239.  Before that the log() function did
>> this:
>>
>> log()
>> {
>>
>> 	/* log to the msg buffer */
>> 	kvprintf(fmt, msglogchar, ...);
>>
>> 	if (!log_open) {
>> 		/* log to console */
>> 		kvprintf(fmt, putchar, ...);
>> 	}
>> }
>>
>> I think your patch is fine unless phk_at_ (cc'd) has a reason for not wanting to
>> do this.
> The reason was systems not running syslog having slow serial consoles.
>

Correct me if I've misunderstood, but that doesn't seem to matter here; 
the proposed change adds logging to the message buffer but leaves 
logging to the console (when no syslog is listening) unchanged.

Eric
Received on Mon Apr 06 2015 - 22:39:45 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:56 UTC