Re: sys/modules "make clean" seems broken again

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512



On 11/19/15 15:42, Warner Losh wrote:
> 
> 
> On Thu, Nov 19, 2015 at 11:12 AM, John Baldwin <jhb_at_freebsd.org 
> <mailto:jhb_at_freebsd.org>> wrote:
> 
> On Thursday, November 19, 2015 09:13:06 AM Sean Bruno wrote:
>> I thought I fixed this a year or two ago, but now a "make clean"
>> in sys/modules seems to leave bus_if.h device_if.h and pci_if.h
>> in the directory.
>> 
>> Should I just add these to the clean targets?
> 
> Blame Warner as his MFILES changes broke this.  In particular, see 
> r287263 which turned off cleaning these up.  I'm not sure what that
> broke that caused it to be disabled.
> 
> Your change is a gross hack though.
> 
> 
> Yes. The reason I had to break it was that there were a few files
> named _if.c and _if.h in the tree that would get deleted when make
> clean was run in the modules.
> 
> I'll take another run at fixing this. Sean's "fix" is a horrible
> hack.
> 
> Warner


Just bouncing a ping here.  I haven't actually checked to see if the
last weeks' commits to head fixed this, but I suspect this hasn't been
addressed.  What do we want to do different if not this hackery I propose?



sean
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQF8BAEBCgBmBQJWXLFzXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCQUFENDYzMkU3MTIxREU4RDIwOTk3REQx
MjAxRUZDQTFFNzI3RTY0AAoJEBIB78oecn5kQGgH/0f9VFqsC2v/CxFSn/oB+n8t
6OwiSZzCQ6D9DQJ259kTFPUXBpOvoDOCrmqxklx0dPov9X9np601CtYlLdz3Ozrk
P3Pg6KrxAq9dZU2TGMm3SSsho6LTvPJ93Up+m0ekk8KRmhntemk1AoUtxShrUFZi
OdEaSxWFfar1cc/6UYhtqXmKcBZXnxdQGkVe0aFCJJDCyuCLWMuIXSO+vjHWvFYF
NUj2fhBHfr1PNX1Hao4j4aR3VfUpLTDclfW0f8e3ABJo2cQ07w935kCPkZQau/8f
ongD795281LJdgamYtB/A0r63xQgzXqeJV6Gk0SRTXU75NUArWfGiweEtMd6wfw=
=RB/W
-----END PGP SIGNATURE-----