Re: sys/modules "make clean" seems broken again

On Mon, Nov 30, 2015 at 1:28 PM, Sean Bruno <sbruno_at_freebsd.org> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
>
>
> On 11/19/15 15:42, Warner Losh wrote:
> >
> >
> > On Thu, Nov 19, 2015 at 11:12 AM, John Baldwin <jhb_at_freebsd.org
> > <mailto:jhb_at_freebsd.org>> wrote:
> >
> > On Thursday, November 19, 2015 09:13:06 AM Sean Bruno wrote:
> >> I thought I fixed this a year or two ago, but now a "make clean"
> >> in sys/modules seems to leave bus_if.h device_if.h and pci_if.h
> >> in the directory.
> >>
> >> Should I just add these to the clean targets?
> >
> > Blame Warner as his MFILES changes broke this.  In particular, see
> > r287263 which turned off cleaning these up.  I'm not sure what that
> > broke that caused it to be disabled.
> >
> > Your change is a gross hack though.
> >
> >
> > Yes. The reason I had to break it was that there were a few files
> > named _if.c and _if.h in the tree that would get deleted when make
> > clean was run in the modules.
> >
> > I'll take another run at fixing this. Sean's "fix" is a horrible
> > hack.
> >
> > Warner
>
>
> Just bouncing a ping here.  I haven't actually checked to see if the
> last weeks' commits to head fixed this, but I suspect this hasn't been
> addressed.  What do we want to do different if not this hackery I propose?
>

Your hackery wouldn't actually fix it completely, just mostly for a common
case.

Warner