Re: Samba 4.3 and 4.4 crashes on FreeBSD 11-ALPHA4

From: Guy Yur <guyyur_at_gmail.com>
Date: Sat, 25 Jun 2016 13:16:40 +0300
Hi,

On Sat, Jun 25, 2016 at 12:20 PM, Konstantin Belousov
<kostikbel_at_gmail.com> wrote:
> On Sat, Jun 25, 2016 at 11:49:39AM +0300, Konstantin Belousov wrote:
>> On Sat, Jun 25, 2016 at 01:03:13AM +0300, Guy Yur wrote:
>> > libtdb.so.1`tdb_runtime_check_for_robust_mutexes + 1475 at mutex.c:957
>> > ...
>>
>> The pointer to tdb_runtime_check_for_robust_mutexes() appeared to be
>> most useful, thanks.
>>
>> The two patches below should fix samba use of robustness. First,
>> kernel erronously reset robust lists locations on fork. Second, the
>> pthread_mutex_trylock() for owned errorcheck mutex must return EDEADLK
>> and not EBUSY.  Try that.
>
> Correction, there was a reason why I initially put the rb list pointers
> into zeroed region.  It still needs to be zeroed on new thread creation.
> Updated patch.
>

With the patch to the 3 files applied, smbd, nmbd and smbclient
no longer crash on my machine.

Tested with r302191+patch.

Thanks,
Guy
Received on Sat Jun 25 2016 - 08:16:43 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:06 UTC