Re: [request for testing] isl, cyapa on chromebooks

On 03/10/2016 19:07, Michael Gmelin wrote:
> I upgraded the latter the r306641, applied your patches (cleanly) and
> ran "make kernel" (GENERIC kernel), added the entries to device.hints
> and rebooted. Unfortunately ig4 won't load:
> 
> # kldload ig4
> link_elf_obj: symbol iicbus_transfer_desc undefined
> linker_load_file: Unsupported file type

Hmm, seems like forgot to declare the iicbus module dependency.
Could you please kldload iicbus and see if that helps?
Meanwhile I'll add the dependency.

> I also noticed that isl cannot be built from the module source
> directory:
> 
> # cd /usr/src/sys/modules/i2c/isl
> # make
> ...
> /usr/src/sys/sys/vnode.h:571:10: fatal error: 'vnode_if.h' file not
> found
> #include "vnode_if.h"
>          ^
> 1 error generated
> *** Error code 1
> 
> This can be easily fixed by removing "#include <sys/vnode.h>" from
> isl.c (line 56).

Thank you for reporting this!
Looks like I overlooked this because I didn't do make clean after removing
vnode_if.h from the Makefile.
Will fix this too.

-- 
Andriy Gapon