Re: r311568 makes freerdp very slow

On Tuesday, January 17, 2017 01:46:31 PM Jakob Alvermark wrote:
> On Fri, January 13, 2017 22:46, Jakob Alvermark wrote:
> > On Fri, January 13, 2017 19:44, John Baldwin wrote:
> >
> >> On Friday, January 13, 2017 09:58:01 AM Jakob Alvermark wrote:
> >>
> >>
> >>> On Thu, January 12, 2017 19:26, John Baldwin wrote:
> >>>
> >>>
> >>>> On Thursday, January 12, 2017 12:42:11 PM Shawn Webb wrote:
> >>>>
> >>>>
> >>>>
> >>>>> On Thu, Jan 12, 2017 at 06:05:08PM +0100, Jakob Alvermark wrote:
> >>>>>
> >>>>>
> >>>>>
> >>>>>> Hi,
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> r311568 Set MORETOCOME for AIO write requests on a socket.
> >>>>>>
> >>>>>> After this commit freerdp is very slow.
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> Before the password prompt would appear immediately when
> >>>>>> connecting to a server. Now it takes 5-10 seconds. After
> >>>>>> entering the password, another 5-10 seconds until I am
> >>>>>> connected. Once connected, there is a considerable lag.
> >>>>>>
> >>>>>>
> >>>>>> What could be the problem?
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>
> >>>>> I don't know what the problem is, but I am seeing the same
> >>>>> symptom.
> >>>>>
> >>>>>
> >>>>
> >>>> Can you get a ktrace of the freerdp process during this?  The
> >>>> commit should only be setting MORETOCOME if multiple aio_write
> >>>> requests are queued to the same socket (so that TCP can batch them
> >>>> into a single packet). However, it should not affect an application
> >>>> just calling aio_write() on a socket once.
> >>>>
> >>>> --
> >>>> John Baldwin
> >>>>
> >>>>
> >>>
> >>> Hi John,
> >>>
> >>>
> >>>
> >>> I got the ktrace, what do I do with it?
> >>>
> >>>
> >>
> >> kdump will generate a text representation, perhaps using 'kdump -s' to
> >> not include dumps of raw I/O data.  If you can put the output of kdump
> >> at a URL I can fetch from then I can look at it.
> >>
> >
> > OK, here it is: http://filebin.ca/38mkuLau9Yqu/ktrace.out.xfreerdp.txt
> >
> >
> > Thanks,
> >
> >
> > Jakob
> 
> Hi,
> 
> Did you get any chance to look at this?

I have not yet, but can you please try the fix in r312387?

-- 
John Baldwin