Re: [PATCH] Recent libm additions

From: Steve Kargl <sgk_at_troutmask.apl.washington.edu>
Date: Sun, 15 Jul 2018 11:26:00 -0700
On Sun, Jul 15, 2018 at 10:21:25AM -0700, K. Macy wrote:
> >
> > Well, actually, the functions in polevll.c should have been copied
> > into ld80/e_powl.c, and polevall.c should never have been committed.
> > Unfortunately, the code was not reviewed for correctness.
> 
> That is not correct. Please stop repeating it. Bruce Evans and John
> Baldwin were both looped in. Neither made this observation.

I read the differential review.  The code was not reviewed by John.
He reviewed how it was hooked into the build.  Bruce does not appear
in the differential review.   There is no record on freebsd-numerics
about the patch.

powl on i686-class hardware is likely broken as it does not use
the LD80C macro to construct literal constants.

-- 
Steve
Received on Sun Jul 15 2018 - 16:26:04 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:17 UTC