Re: [PATCH] Recent libm additions

On Sun, Jul 15, 2018 at 10:17 AM, Steve Kargl
<sgk_at_troutmask.apl.washington.edu> wrote:
> On Sun, Jul 15, 2018 at 11:00:41AM -0600, Ian Lepore wrote:
>> On Sun, 2018-07-15 at 08:06 -0700, Steve Kargl wrote:
>> > Index: ld80/e_powl.c
>> > ===================================================================
>> > --- ld80/e_powl.c   (revision 336304)
>> > +++ ld80/e_powl.c   (working copy)
>> > _at__at_ -77,6 +77,7 _at__at_
>> >  #include
>> >
>> >  #include "math_private.h"
>> > +#include "polevll.c"
>>
>> If a file contains inline function definitions and is intended only to
>> be included into another file and not compiled separately, shouldn't
>> its name be spelled polevll.h ?
>>
>
> Well, actually, the functions in polevll.c should have been copied
> into ld80/e_powl.c, and polevall.c should never have been committed.
> Unfortunately, the code was not reviewed for correctness.  I've
> made the minimum changes to address the two issues I've noted.
> Feel free to either copy the functions and delete the polevall.c
> or rename it.
>


In the bug report you cite, Chris Lattner states: "This is actually an
unspecified feature of C99 (whether it supports the _Imaginary type).
It is desirable to support this, but not a regression.

I'm more than happy to commit these changes, but neither including a
.c file nor compensating for the absence of a gcc feature in clang is
a correctness fix. In the future you might wish to subscribe to phab
reviews so that you can be notified when changes like this are under
consideration. Thank you for your input.

-M