Re: [PATCH] Recent libm additions

From: Steve Kargl <sgk_at_troutmask.apl.washington.edu>
Date: Sun, 15 Jul 2018 10:17:37 -0700
On Sun, Jul 15, 2018 at 11:00:41AM -0600, Ian Lepore wrote:
> On Sun, 2018-07-15 at 08:06 -0700, Steve Kargl wrote:
> > Index: ld80/e_powl.c
> > ===================================================================
> > --- ld80/e_powl.c	(revision 336304)
> > +++ ld80/e_powl.c	(working copy)
> > _at__at_ -77,6 +77,7 _at__at_
> >  #include 
> >  
> >  #include "math_private.h"
> > +#include "polevll.c"
> 
> If a file contains inline function definitions and is intended only to
> be included into another file and not compiled separately, shouldn't
> its name be spelled polevll.h ?
> 

Well, actually, the functions in polevll.c should have been copied
into ld80/e_powl.c, and polevall.c should never have been committed.
Unfortunately, the code was not reviewed for correctness.  I've
made the minimum changes to address the two issues I've noted.
Feel free to either copy the functions and delete the polevall.c
or rename it.

-- 
Steve
Received on Sun Jul 15 2018 - 15:17:39 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:17 UTC