RE: [PATCH] Recent libm additions

That'll work too.

---
Sent using a tiny phone keyboard.
Apologies for any typos and autocorrect.
Also, this old phone only supports top post. Apologies.

Cy Schubert
<Cy.Schubert_at_cschubert.com> or <cy_at_freebsd.org>
The need of the many outweighs the greed of the few.
---

-----Original Message-----
From: Warner Losh
Sent: 15/07/2018 12:26
To: Cy Schubert
Cc: Ian Lepore; K. Macy; Steve Kargl; FreeBSD Current
Subject: Re: [PATCH] Recent libm additions

So something like this:




diff --git a/MAINTAINERS b/MAINTAINERS

index 51d3688f8b8..3e6584f24a1 100644

--- a/MAINTAINERS

+++ b/MAINTAINERS

_at__at_ -58,6 +58,7 _at__at_ kqueue                jmg     Pre-commit review requested.  Documentation Required.

 libdpv         dteske  Pre-commit review requested. Keep in sync with dpv(1).

 libfetch       des     Pre-commit review requested, email only.

 libfigpar      dteske  Pre-commit review requested.

+libm           freebsd-numerics        Send email with patches to freebsd-numerics_at_

 libpam         des     Pre-commit review requested, email only.

 linprocfs      des     Pre-commit review requested, email only.

 lpr            gad     Pre-commit review requested, particularly for




is what you're suggesting?




Warner



On Sun, Jul 15, 2018 at 1:23 PM, Cy Schubert <Cy.Schubert_at_cschubert.com> wrote:




I wasn't saying Steve has a lock however in case non-committers might feel they do, addressing all points in my reply. Not saying anyone feels this way today but we should consider this in whatever we decide here (considering all possibilities). IMO adding subject matter experts to MAINTAINERS seems like the easiest way to document who might be the go-to person.

---
Sent using a tiny phone keyboard.
Apologies for any typos and autocorrect.
Also, this old phone only supports top post. Apologies.

Cy Schubert
<Cy.Schubert_at_cschubert.com> or <cy_at_freebsd.org>
The need of the many outweighs the greed of the few.
---



From: Warner Losh
Sent: 15/07/2018 12:09
To: Cy Schubert
Cc: Ian Lepore; K. Macy; Steve Kargl; FreeBSD Current


Subject: Re: [PATCH] Recent libm additions


I'm not saying that he has a lock. I'm saying he's are domain expert and many mistakes can be avoided by talking to him.



I'm saying we have history here, and that history, while poorly documented, wasn't followed. To the extent it is poorly documented, we should fix that.




Warner





On Sun, Jul 15, 2018 at 12:43 PM, Cy Schubert <Cy.Schubert_at_cschubert.com> wrote:




I don't think it makes sense for a non-committer to have a lock on anything in base. However a request for review makes a lot of sense. If a non-committer or former committer is the SME on a particular subject it's best that they be consulted even if they don't request it. IMO more input is better. Where better to document this than in MAINTAINERS.

Having said all this. If a person is a former committer and it's not documented, how are we to know?

If people agree, should we start documenting SMEs in MAINTAINERS?

---
Sent using a tiny phone keyboard.
Apologies for any typos and autocorrect.
Also, this old phone only supports top post. Apologies.

Cy Schubert
<Cy.Schubert_at_cschubert.com> or <cy_at_freebsd.org>
The need of the many outweighs the greed of the few.
---



From: Ian Lepore
Sent: 15/07/2018 11:08
To: Warner Losh; K. Macy
Cc: Steve Kargl; FreeBSD Current
Subject: Re: [PATCH] Recent libm additions

On Sun, 2018-07-15 at 11:55 -0600, Warner Losh wrote:
> On Sun, Jul 15, 2018, 11:23 AM K. Macy <kmacy_at_freebsd.org> wrote:
> 
> > 
> > > 
> > > 
> > > Well, actually, the functions in polevll.c should have been
> > > copied
> > > into ld80/e_powl.c, and polevall.c should never have been
> > > committed.
> > > Unfortunately, the code was not reviewed for correctness.
> > That is not correct. Please stop repeating it. Bruce Evans and John
> > Baldwin were both looped in. Neither made this observation.
> > 
> Steve is the fp guy these days. And it wasn't reviewed by him. He's
> mad you
> cut him out of the loop. Arguing about pedantic points of process
> does no
> one any good.
> 
> Warner

On the other hand, what information is there for someone to know that
Steve should be involved in a review? There is nothing in MAINTAINERS.
The review was on phab for almost a month, and phab is supposedly the
preferred way to do reviews these days.

Steve is no longer a committer, but that doesn't preclude him having a
phab account and participating in reviews. If he doesn't like using
phab (and I can certainly understand that POV), an entry in MAINTAINERS
would still be helpful, unless we have a rule that only committers can
be listed in there.

-- Ian

_______________________________________________
freebsd-current_at_freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"