Re: r339289 buildworld stopped in /usr/src/secure/lib/libcrypto

On Thu, Oct 11, 2018 at 04:44:10PM -0500, Justin Hibbits wrote:
> On Thu, 11 Oct 2018 17:32:21 -0400
> Jung-uk Kim <jkim_at_FreeBSD.org> wrote:
> 
> > On 18. 10. 11., Justin Hibbits wrote:
> > > On Thu, 11 Oct 2018 19:07:45 +0000
> > > Glen Barber <gjb_at_freebsd.org> wrote:
> > >   
> > >> On Thu, Oct 11, 2018 at 09:05:52AM +0200, Raúl wrote:  
> > >>> Maybe related to recent Glen's Heads-UP?
> > >>>
> > >>> https://lists.freebsd.org/pipermail/freebsd-current/2018-October/071581.html
> > >>>     
> > >>
> > >> No, this is different, and more recent than the heads-up.  I now
> > >> see failures on powerpc, powerpc64, powerpcspe, sparc64, and arm.
> > >>
> > >> I'm trying to track down what commit introduced this, but it was
> > >> not the final merge from the projects/openssl111 branch.
> > >>
> > >> Glen
> > >>  
> > > 
> > > Seems r339303 is the cuplrit.  Reverting this gets my build
> > > completing.  
> > 
> > It seems ldns now requires libssl.so to support DANE-TA.  Please try
> > the attached patch.
> > 
> > Jung-uk Kim
> 
> Just patching lib/libldns is insufficient.  share/mk/src.libnames.mk
> needs updated as well.  Here's a patch I tested, attached.
> 
> - Justin

> Index: lib/libldns/Makefile
> ===================================================================
> --- lib/libldns/Makefile	(revision 339318)
> +++ lib/libldns/Makefile	(working copy)
> _at__at_ -19,7 +19,7 _at__at_
>  
>  SRCS+=	b64_ntop.c b64_pton.c
>  
> -LIBADD=	crypto
> +LIBADD=	ssl crypto
>  
>  WARNS ?= 3
>  
> Index: share/mk/src.libnames.mk
> ===================================================================
> --- share/mk/src.libnames.mk	(revision 339318)
> +++ share/mk/src.libnames.mk	(working copy)
> _at__at_ -273,7 +273,7 _at__at_
>  _DP_memstat=	kvm
>  _DP_magic=	z
>  _DP_mt=		sbuf bsdxml
> -_DP_ldns=	crypto
> +_DP_ldns=	ssl crypto
>  .if ${MK_OPENSSL} != "no"
>  _DP_fetch=	ssl crypto
>  .else

I still see a failure with this applied.

 ===> lib/libldns (obj,all,install)
 /usr/obj/usr/src/powerpc.powerpc/tmp/usr/bin/ld: cannot find -lssl
 --- libprivateldns.so.5.full ---
 *** [libprivateldns.so.5.full] Error code 1

I'll prune .OBJDIR and re-run without -jN to eliminate the possibility
of a build race.

Glen