Re: careless commits disrupt

I wrote:
> Stefan Esser wrote:
> > Am 11.10.18 um 18:20 schrieb Julian H. Stacey:
> > >> On Thu, Oct 11, 2018 at 05:54:08PM +0200, Julian H. Stacey wrote:
> > >>> ....
> > >>> 3_sxnet.pico v3_tlsf.pico v3_utl.pico v3err.pico |  tsort -q`  -lpthread
> > >>> /usr/bin/ld: error: unable to find library -lpthread
> > >>> cc: error: linker command failed with exit code 1 (use -v to see invocati=
> > >> on)
> > >>> *** Error code 1
> > >>> =20
> > >>> Stop.
> > >>> make[4]: stopped in /usr/src/secure/lib/libcrypto
> > >>> =20
> > >>> Yes I'm current:
> > >>> 	.ctm_status src-cur 13733
> > >>> 	.svn_revision 339303
> > >>> ....
> > >>
> > >> I had no issues this morning performing a src-based update from
> > >> head/amd64 _at_r339278 to r339303 -- either on my laptop or my build
> > >> machine.
> > > 
> > > Hi David, 
> > > Then it seems this one is hopefuly my local problem then,
> > > so I'll revert to vanilla r339303 & retry. Thanks.
> > 
> > It worked for me when I started with a clean /usr/obj.
> > 
> > You should also delete old files:
> > 
> > cd /usr/src
> > make delete-old
> > make delete-old-libs
> 
> Thanks Stefan,
> I just ran that. It deleted lots of stuff. & I'd only run it 2 days ago.
> I should have run it just before buildworld though.
> It's not suggested in the top of 
>   https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/makeworld.html
> just at base of page. I also tossed in ldconfig -R
> 
> Maybe many current people already use a src.conf with
> 	NEED_MAKE_UPGRADE=YES
> I must read Makefile[.inc1] more, but hacked a temporarily patch
> 
> *** Makefile.pre_jhs	Thu Oct 11 20:39:25 2018
> --- Makefile	Thu Oct 11 21:07:50 2018
> ***************
> *** 419,428 ****
>   # Perform a few tests to determine if the installed tools are adequate
>   # for building the world.
>   #
> ! upgrade_checks: .PHONY
>   .if defined(NEED_MAKE_UPGRADE)
>   	_at_${_+_}(cd ${.CURDIR} && ${MAKE} ${WANT_MAKE:S,^f,,})
>   .endif
>   
>   #
>   # Upgrade make(1) to the current version using the installed
> --- 419,434 ----
>   # Perform a few tests to determine if the installed tools are adequate
>   # for building the world.
>   #
> ! upgrade_checks: .PHONY suggest_delete_old
>   .if defined(NEED_MAKE_UPGRADE)
>   	_at_${_+_}(cd ${.CURDIR} && ${MAKE} ${WANT_MAKE:S,^f,,})
>   .endif
> + 
> + suggest_delete_old:
> + 	_at_echo "If buildworld breaks, first try:"
> + 	_at_echo "make delete-old"
> + 	_at_echo "make delete-old-libs"
> + 	_at_echo "ldconfig -R"
>   
>   #
>   # Upgrade make(1) to the current version using the installed
> 

Another buildworld failed with 
	pico v3_tlsf.pico v3_utl.pico v3err.pico |  tsort -q`  -lpthread
	/usr/bin/ld: error: unable to find library -lpthread
	cc: error: linker command failed with exit code 1 (use -v to see invocation)
	*** Error code 1
	
	Stop.
	make[4]: stopped in /usr/src/secure/lib/libcrypto
	*** Error code 1

Then on both hosts with vanilla r339303
 cd /usr/src/lib/libthr; make failed with 
	cc -O2 -pipe -DBERKLIX=YES -I/usr/src/lib/libnetbsd -I/usr/src/contrib/netbsd-tests -g -std=gnu99 -fstack-protector-strong -Qunused-arguments  -L/1s4/obj/1s1/usr/src/amd64.amd64/lib/libnetbsd  -o barrier_test.full t_barrier.o  -lprivateatf-c -L/1s4/obj/1s1/usr/src/amd64.amd64/lib/libthr -L/1s4/obj/1s1/usr/src/amd64.amd64/lib/libnetbsd -lnetbsd -lpthread
	/usr/bin/ld: error: unable to find library -lnetbsd
	cc: error: linker command failed with exit code 1 (use -v to see invocation)
	*** Error code 1
	
	Stop.
	make[2]: stopped in /usr/src/lib/libthr/tests

Then 
cd /usr/src/lib/libnetbsd ; make	# OK
cd /usr/src/lib/libthr; make		# OK
cd /usr/src/secure/lib/libcrypto ; make		# OK
cd /usr/src/secure/lib ; make
	cc  -O2 -pipe -DBERKLIX=YES   -DHAVE_LDNS=1 -I/usr/src/contrib/ldns -I/usr/src/crypto/openssh -include ssh_namespace.h -include krb5_config.h -g -MD  -MF.depend.getrrsetbyname-ldns.o -MTgetrrsetbyname-ldns.o -std=gnu99 -fstack-protector-strong -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-local-typedef -Wno-address-of-packed-member -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -Wno-parentheses  -Qunused-arguments  -c /usr/src/crypto/openssh/openbsd-compat/getrrsetbyname-ldns.c -o getrrsetbyname-ldns.o
	In file included from /usr/src/crypto/openssh/openbsd-compat/getrrsetbyname-ldns.c:53:
	In file included from /usr/src/contrib/ldns/ldns/ldns.h:98:
	In file included from /usr/src/contrib/ldns/ldns/dane.h:30:
	/usr/include/openssl/ssl.h:165:11: fatal error: 'openssl/kssl.h' file not found
	# include <openssl/kssl.h>
	          ^~~~~~~~~~~~~~~~
	1 error generated.
	*** Error code 1
	
	Stop.
	make[1]: stopped in /usr/src/secure/lib/libssh


Back a step:
cd /usr/src ; make depend # OK
make buildworld # running

Cheers,
Julian
-- 
Julian Stacey, Computer Consultant, Systems Engineer, BSD Linux Unix, Munich
 Brexit: 3,700,000 stolen votes in 1st referendum inc. 700,000 from Brits in EU
 Campaign lies & criminal funding, economy & pound down: New referendum needed.
	http://exitbrexit.uk	https://www.peoples-vote.uk/petition