Re: drm-legacy is broken, again

From: Niclas Zeising <zeising_at_freebsd.org>
Date: Thu, 1 Aug 2019 22:09:53 +0200
On 2019-08-01 21:42, Steve Kargl wrote:
> On Thu, Aug 01, 2019 at 03:31:15PM -0400, Mark Johnston wrote:
>> On Thu, Aug 01, 2019 at 12:30:24PM -0700, Steve Kargl wrote:
>>> On Thu, Aug 01, 2019 at 03:22:27PM -0400, Mark Johnston wrote:
>>>> On Thu, Aug 01, 2019 at 12:10:09PM -0700, Steve Kargl wrote:
>>>>> Just updated /usr/src to top of tree.
>>>>>
>>>>> Trying to update drm-legacy port.  After
>>>>> a failed 'make' in /usr/ports/drm-legacy
>>>>
>>>> The patch below should fix it.  drm was relying on refcount.h including
>>>> limits.h.
>>>>
>>>> diff --git a/src/dev/drm2/drmP.h b/src/dev/drm2/drmP.h
>>>> index 3af7ad1..7cbd8db 100644
>>>> --- a/src/dev/drm2/drmP.h
>>>> +++ b/src/dev/drm2/drmP.h
>>>> _at__at_ -42,6 +42,7 _at__at_ __FBSDID("$FreeBSD$");
>>>>   
>>>>   #include <sys/param.h>
>>>>   #include <sys/queue.h>
>>>> +#include <sys/limits.h>
>>>>   #include <sys/malloc.h>
>>>>   #include <sys/kernel.h>
>>>>   #include <sys/ktr.h>
>>>
>>> Thanks for the quick response.  I had recalled someone
>>> has/had been undoing some header pollution changes,
>>> but the individual names escaped me.
>>
>> I reproduced the issue and submitted a PR:
>> https://github.com/FreeBSDDesktop/drm-legacy/pull/13
> 
> 
> Thanks for that, too.  I'm not in a position to
> submit a PR as my mouse has gone missing under
> Xorg.
> 

Port has been updated:
https://svnweb.freebsd.org/changeset/ports/507828
Regards
-- 
Niclas Zeising
Received on Thu Aug 01 2019 - 18:10:02 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:41:21 UTC