Re: SVN r355491 breaks libprocstat

On Sat, 7 Dec 2019 12:57-0500, Michael Butler wrote:

> This member removal has other consequences. As follows ..
> 
> --- lib/libprocstat__L ---
> Building /usr/obj/usr/src/amd64.amd64/lib/libprocstat/smbfs.o
> --- libprocstat.o ---
> /usr/src/lib/libprocstat/libprocstat.c:620:29: error: no member named
> 'next' in 'struct vm_map_entry'
>                 for (entryp = map->header.next;
>                               ~~~~~~~~~~~ ^
> /usr/src/lib/libprocstat/libprocstat.c:622:24: error: no member named
> 'next' in 'struct vm_map_entry'
>                     entryp = vmentry.next) {
>                              ~~~~~~~ ^
> 2 errors generated.

Now we seem to be missing the prototypes:

--- libprocstat.o ---                                                                                                                                                                                                                                                                                                          
/usr/src/lib/libprocstat/libprocstat.c:620:17: error: implicit declaration of function 'vm_map_entry_first' is invalid in C99 
[-Werror,-Wimplicit-function-declaration]                                                                                                                                                        
                for (entryp = vm_map_entry_first(map);                                                                                                                                                                                                                                                                         
                              ^                                                                                                                                                                                                                                                                                                
/usr/src/lib/libprocstat/libprocstat.c:620:15: error: incompatible 
integer to pointer conversion assigning to 'vm_map_entry_t' (aka 
'struct vm_map_entry *') from 'int' [-Werror,-Wint-conversion]                                                                                                                             
                for (entryp = vm_map_entry_first(map);                                                                                                                                                                                                                                                                         
                            ^ ~~~~~~~~~~~~~~~~~~~~~~~                                                                                                                                                                                                                                                                          
/usr/src/lib/libprocstat/libprocstat.c:622:16: error: implicit declaration of function 'vm_map_entry_succ' is invalid in C99 
[-Werror,-Wimplicit-function-declaration]                                                                                                                                                         
                    entryp = vm_map_entry_succ(&vmentry)) {                                                                                                                                                                                                                                                                    
                             ^                                                                                                                                                                                                                                                                                                 
/usr/src/lib/libprocstat/libprocstat.c:622:16: note: did you mean 'vm_map_entry_first'?                                                                                                                                                                                                                                        
/usr/src/lib/libprocstat/libprocstat.c:620:17: note: 'vm_map_entry_first' declared here                                                                                                                                                                                                                                        

I'm at r355504.

-- 
Trond.