Re: OpenSSL breaks factor(6)

On Sun, Dec 29, 2019 at 08:02:47AM -0800, Steve Kargl wrote:
> Here's a final attempt at fixing and documenting FreeBSD's factor(6).
> Do what you want with the patch.  With and without OpenSSL, one now
> gets
> 
> % factor +123 123 123zzzz 123zabc 123abc +123abc 0x123abc +0x123abc
> 123: 3 41
> 123: 3 41
> 123: 3 41
> 123: 3 41
> 1194684: 2 2 3 29 3433
> 1194684: 2 2 3 29 3433
> 1194684: 2 2 3 29 3433
> 1194684: 2 2 3 29 3433
> 
> * usr.bin/factor/factor.6:
>   . Update documentation to note that hexadecimal strings are accepted.
>   . Document that a hexadecimal number can have an optional 0x or 0X prefix.
>   . Document that a 0 value in interactive mode terminates factor(6).
>   . Fix the maximum value for 'stop' in primes(6).
>   . While here, spell "white-space" as "whitespace" and "non-digit" as
>     "nondigit".
> 
> * usr.bin/factor/factor.c:
>   . Include stdbool to get acces to bool type.
>   . Use consistent style for function prototypes.
>   . New function. is_hex_str() looks for the longest substring and 
>     determines if it is a hexadecimal number.
>   . New function.  Factor (pun intended) out common code into convert_str2bn().
>   . For the WIHTOUT_OPENSSL case, make BN_dec2bn() and BN_hex2bn() return 0
>     on error like their OpenSSL counterparts.
> 
> * usr.bin/primes/primes.c:
>   . Fix comment.
>  

This is now

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243136

-- 
steve