Re: r360902 breaks VLAN interface on if_em (82579LM)

Hi

I'm told the content was stripped from my emails...

I noticed that my VLAN interfaces stopped working after a recent build.  
tcpdump showed traffic leaving leaving and entering the interface but no 
host on the network actually received any packets from this host.  A 
binary search led me to r360902 and indeed the following change fixed 
the issue for me:

Index: sys/dev/e1000/if_em.c
===================================================================
--- sys/dev/e1000/if_em.c       (revision 361538)
+++ sys/dev/e1000/if_em.c       (working copy)
_at__at_ -4054,7 +4054,7 _at__at_
  {
         switch (event) {
         case IFLIB_RESTART_VLAN_CONFIG:
-               return (false);
+               return (true);
         default:
                 return (true);
         }

Hardware according to pciconf is:

em0_at_pci0:0:25:0:        class=0x020000 rev=0x04 hdr=0x00 vendor=0x8086 
device=0x1502 subvendor=0x103c subdevice=0x1495
     vendor     = 'Intel Corporation'
     device     = '82579LM Gigabit Network Connection (Lewisville)'
     class      = network
     subclass   = ethernet
     cap 01[c8] = powerspec 2  supports D0 D3  current D0
     cap 05[d0] = MSI supports 1 message, 64 bit enabled with 1 message
     cap 13[e0] = PCI Advanced Features: FLR TP

Ian

-- 
Ian Freislich