On Fri, Feb 06, 2004 at 03:52:44PM +1100, Bruce Evans wrote: [...] > > > That is slow too. I get 12.12 seconds with make, 2.36 with make -j1, > > > 1.37 with a shell loop and bash-1, 1.35 with a shell loop and /bin/sh, > > > and 0.0042 with jot 1000 >/dev/null. > > > > > Shell loops aren't an option here. I realize that we loose speed here, > > but we gain a feature. > > Ah, but I always choose speed over features (except reverse creeping ones) :-). > Sorry, I meant "but we fix a bug". > 0.18 seconds in bin/cat is huge. > Yep, given that most people don't need it. Do you have an idea of how to do it properly, as even making heuristics on the number of source files to select the "make depend" algorithm doesn't seem right to me? Perhaps in the meantime, I should just add an undocumented knob, _SAFE_MKDEP (please suggest a better name), and provide both versions of "make depend", with the old version as default? > A null "make depend" is when .depend is not stale (an maybe all > relevant disk blocks are cached). > A null "make depend" is not affected by this change. > > Yes, but ``grep ^MKDEPCMD bsd.dep.mk'' to see what I'm talking > > about. > > I know. MKDEPCMD should be put in the environment before execing > xargs instead of after to avoid the env process. It seems to the > only thing that needs to be put in the environment here. See the > similar cleanup in kern.post.mk. > Please see my other message with the patch that splits environment variables from command name. Cheers, -- Ruslan Ermilov FreeBSD committer ru_at_FreeBSD.org
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:37:42 UTC