[brooks_at_FreeBSD.ORG: [src] cvs commit: src/etc pccard_ether]

I've just committed the following change to /etc/pccard_ether.  I think
it's the right solution, but I'm concerned it may cause problems with
drivers that incorrectly frob the IFF_UP flag themselves.  If so it may
be nessicary to revert this change temporarily or at least not MFC it.

-- Brooks

----- Forwarded message from Brooks Davis <brooks_at_FreeBSD.ORG> -----

From: Brooks Davis <brooks_at_FreeBSD.ORG>
Date: Wed, 28 Sep 2005 19:59:23 +0000 (GMT)
To: brooks_at_FreeBSD.ORG
Subject: [src] cvs commit: src/etc pccard_ether

brooks      2005-09-28 19:59:18 UTC

  FreeBSD src repository

  Modified files:
    etc                  pccard_ether 
  Log:
  Be less IPv4 centric.  When checking if the interface is already
  configured, check if the UP flag is set instead of checking for the
  netmask keyword.
  
  Revision  Changes    Path
  1.47      +1 -1      src/etc/pccard_ether


Index: src/etc/pccard_ether
diff -u src/etc/pccard_ether:1.46 src/etc/pccard_ether:1.47
--- src/etc/pccard_ether:1.46	Wed Aug 24 01:23:49 2005
+++ src/etc/pccard_ether	Wed Sep 28 19:59:18 2005
_at__at_ -71,7 +71,7 _at__at_
 case ${startstop} in
 [Ss][Tt][Aa][Rr][Tt] | '')
 	if [ -x /usr/bin/grep ]; then
-		if ifconfig $ifn | grep -s netmask > /dev/null 2>&1; then
+		if ifconfig $ifn | grep -s '[<,]UP[,>]' > /dev/null 2>&1; then
 		    # Interface is already up, so ignore it.
 		    exit 0
 		fi

----- End forwarded message -----
-- 
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4