Re: "ifconfig -vlandev" syntax

From: Yar Tikhiy <yar_at_comp.chem.msu.su>
Date: Fri, 30 Sep 2005 03:33:13 +0400
On Thu, Sep 29, 2005 at 04:15:24PM -0700, Brooks Davis wrote:
> On Thu, Sep 29, 2005 at 06:23:10PM +0200, Fredrik Lindberg wrote:
> > Yar Tikhiy wrote:
> > >On Sun, Sep 25, 2005 at 02:37:41PM -0700, Brooks Davis wrote:
> > >
> > >>On Thu, Sep 22, 2005 at 02:41:05PM +0400, Yar Tikhiy wrote:
> > >>
> > >>>As our ifconfig(8) is growing more options for special interface
> > >>>types, inconsistencies sneak into their syntax.  In particular,
> > >>>-vlandev takes a useless argument (vlan(4) cannot attach to more
> > >>>than one parent anyway) while, e.g., -carpdev doesn't need one.
> > >>>Personally, I like the latter since having to type unneeded words
> > >>>on the command line annoys me.  Do you think that making -vlandev
> > >>>need no arguments in CURRENT would break many existing things?
> > >>
> > >>I agree the argument is useless.  Unfortunatly, it's going to be hard to
> > >>deprecate the old syntax so we may need to keep it around.
> > >
> > >
> > >Alas, there doesn't seem to exist an easy way to support both
> > >syntaxes in the ifconfig(8) parameter parser.  Perhaps we can
> > >survive the pain of syntax change in CURRENT only, with a
> > >heads-up message sent, release notes updated, etc?  I wonder
> > >if many people use "ifconfig -vlandev XXX" in automated tools.
> > >
> > 
> > Why not use something simple such as the following (maybe even
> > without that printf().
> > 
> > root_at_genesis> ./ifconfig vlan0 create
> > root_at_genesis> ./ifconfig vlan0 vlan 1 vlandev em0
> > root_at_genesis> ./ifconfig vlan0 -vlandev
> > root_at_genesis> ./ifconfig vlan0 vlan 1 vlandev em0
> > root_at_genesis> ./ifconfig vlan0 -vlandev em0
> > Passing interface to -vlandev is deprecated.
> 
> Excellent, this is the perfect solution.  Let's get something like this
> committed and MFC'd so it goes out in 6.0.

Working on this right now...

-- 
Yar
Received on Thu Sep 29 2005 - 21:33:17 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:38:44 UTC