Re: bus_get_dma_tag now necessary for drivers using bus_dma

From: Poul-Henning Kamp <phk_at_phk.freebsd.dk>
Date: Tue, 05 Sep 2006 17:44:48 +0000
In message <20060905173334.GH9421_at_funkthat.com>, John-Mark Gurney writes:

>This means that for each call to bus_dma_tag_create, instead of passing
>a NULL pointer, you should call bus_get_dma_tag(yourdev) and use that
>as the parent tag.  I committed some example code to various drivers,
>such as ahc, ata, em, and ohci.

If there are never any exeptions to this requirement, why not
pass "yourdev" and have the magic hidden, rather than add 17
ritual characters to the API ?

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk_at_FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.
Received on Tue Sep 05 2006 - 15:44:56 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:00 UTC