Re: bus_get_dma_tag now necessary for drivers using bus_dma

From: M. Warner Losh <imp_at_bsdimp.com>
Date: Tue, 05 Sep 2006 13:02:47 -0600 (MDT)
In message: <14026.1157478288_at_critter.freebsd.dk>
            "Poul-Henning Kamp" <phk_at_phk.freebsd.dk> writes:
: In message <20060905173334.GH9421_at_funkthat.com>, John-Mark Gurney writes:
: 
: >This means that for each call to bus_dma_tag_create, instead of passing
: >a NULL pointer, you should call bus_get_dma_tag(yourdev) and use that
: >as the parent tag.  I committed some example code to various drivers,
: >such as ahc, ata, em, and ohci.
: 
: If there are never any exeptions to this requirement, why not
: pass "yourdev" and have the magic hidden, rather than add 17
: ritual characters to the API ?

As Scott pointed out, it won't always be NULL.  I like his idea of
having a variant that takes a device_t...

Warner
Received on Tue Sep 05 2006 - 17:09:14 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:00 UTC