Re: bus_get_dma_tag now necessary for drivers using bus_dma

From: Scott Long <scottl_at_samsco.org>
Date: Tue, 05 Sep 2006 12:31:20 -0600
Poul-Henning Kamp wrote:
> In message <20060905173334.GH9421_at_funkthat.com>, John-Mark Gurney writes:
> 
> 
>>This means that for each call to bus_dma_tag_create, instead of passing
>>a NULL pointer, you should call bus_get_dma_tag(yourdev) and use that
>>as the parent tag.  I committed some example code to various drivers,
>>such as ahc, ata, em, and ohci.
> 
> 
> If there are never any exeptions to this requirement, why not
> pass "yourdev" and have the magic hidden, rather than add 17
> ritual characters to the API ?
> 

Drivers can have their own multi-level tag heirarchy.  You'd have to
create a new bus_dma_tag_create() variant that expected a device_t
instead of a bus_dma_tag_t.  This might be a good idea.

Scott
Received on Tue Sep 05 2006 - 16:31:37 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:39:00 UTC