Re: sendfile() without struct sf_hdtr broken since rev 1.256

Rong-en Fan wrote:
> On 9/22/07, Marcus Alves Grand <mnag_at_freebsd.org> wrote:
>> People,
>>
>> Since rev 1.256 sendfile broken lighttpd sendfile() that doesn´t use
>> struct sf_hdtr.
>>
>> Sometimes sendfile works sometimes not like you can see below:
>>
> [...]
>> rev 1.256:
>> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/kern/uipc_syscalls.c.diff?r1=1.255;r2=1.256
> 
> Thank you for finding this out. I encountered exactly the same
> problem but have no time to investigate.
> 
> BTW, if I downgrade lighttpd to 1.4.16 from 1.4.17/1.4.18, with
> rev 1.256 uipc_syscalls.c it works.

Ok. I commit one fix for lighttpd. But i still think there´s a problem 
in sendfile().

For example, if i revert rev 1.256 sendfile return "off_t *sbytes" > 0 
otherwise sendfile() return 0 in sbytes many times.

Someone know if this new behavior are correct?

Regards

> 
> Regards,
> Rong-En Fan
> 
>> Regards
>> _______________________________________________
>> freebsd-current_at_freebsd.org mailing list
>> http://lists.freebsd.org/mailman/listinfo/freebsd-current
>> To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> freebsd-current_at_freebsd.org mailing list
>> http://lists.freebsd.org/mailman/listinfo/freebsd-current
>> To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"

-- 
Marcus Alves Grando
marcus(at)sbh.eng.br | Personal
mnag(at)FreeBSD.org  | FreeBSD.org