Re: 8.0-BETA1 bsdlabel broken?

G'day.

Fri, Jul 10, 2009 at 10:15:27AM -0700, Marcel Moolenaar wrote:
> There is no need for the verb. bsdlabel should use the same
> logic the kernel is using: if the C partition has a non-zero
> offset, then the label is absolute and you can subtract that
> offset from all partitions to make the label relative.

OK, the attached patch should solve the issue in the bsdlabel:
it really uses the offset of the 'c' partition to make offsets
to be relative.

Sat, Jul 11, 2009 at 06:24:14PM +1000, John Marshall wrote:
> > Can you send me the output of "gpart show da0" and "gpart show da0s1".
> > Could you also send me (or make available for download) a binary dump
> > of sectors 0 (the MBR), 63 and 64 (the disklabel in slice 1).
> 
> I have backed out the inclusion of GEOM_BSD in the kernel and no longer
> have the WARNING messages appearing in dmesg.

Yes, sorry -- it was my fault to advise to include it.

Please, try the attached patch -- it should heal bsdlabel and it will
show/use the proper offsets everywhere.  Works fine for me -- offsets
for 7.x and 8.x are the same.

Fri, Jul 10, 2009 at 09:33:10AM -0700, Marcel Moolenaar wrote:
> Please don't use GEOM_BSD. It's obsolete. I haven't removed
> the code out of conservatism, but consider it dead and gone.
> 
> As a special warning: you should not have both GEOM_PART_BSD
> and GEOM_BSD. My gut feeling tells me that you have both and
> that's why you have the mess you're having.

Then I would add a bit stronger warning about the GEOM_BSD into
/usr/src/UPDATING -- the current one (from 20090320) is rather mild in
respect of the obsoletenness of GEOM_BSD.  And since GEOM_PART_* seem to
be included by-default, it will produce the mess I had seen when
GEOM_BSD is included too.  It will be good to embed the checks for
incompatible options into config(8).  I'll draft the needed patches
for config(8).
-- 
Eygene
 _                ___       _.--.   #
 \`.|\..----...-'`   `-._.-'_.-'`   #  Remember that it is hard
 /  ' `         ,       __.--'      #  to read the on-line manual
 )/' _/     \   `-_,   /            #  while single-stepping the kernel.
 `-'" `"\_  ,_.-;_.-\_ ',  fsc/as   #
     _.-'_./   {_.'   ; /           #    -- FreeBSD Developers handbook
    {_.-``-'         {_/            #