Re: CFT: ee 1.5.0

On Tue, May 26, 2009 at 11:39:21PM +0200, Ed Schouten wrote:

  Hi all,
  
  Some days ago Bruce Cran and I were talking on IRC about the ancient
  version of ee(1) we have in the tree. Today I spent some time moving
  ee(1) to contrib/ee with proper mergeinfo in place, to make it easier to
  upgrade it.
  
  It turns out all local modifications we have to ee(1) right now (line
  numbers, mktemp, etc) have been implemented upstream as well, in most
  cases even better. So I've decided to switch to an almost clean copy of
  ee(1).
  
  My patch so far (requires a very recent source tree):
  
  	http://80386.nl/pub/ee-freebsd-1.5.0.diff
  
  Any comments before I commit this patch to SVN?
  

After using the new ee in a -current build, it seems like an old issue
has come back where if the containing xterm is resized, ee ungracefully
exits without saving.  I think it was fixed a while ago but a quick look
at the modern ee.c seems to indicate this was lost:


Revision 1.25: download - view: text, markup, annotated - select for diffs
Sat Jul 28 22:40:10 2001 UTC (7 years, 10 months ago) by mp
Branches: MAIN
Diff to: previous 1.24: preferred, colored
Changes since revision 1.24: +5 -10 lines

Properly handle wgetch(3) returning ERR. This prevents an abnormal exit
when a windows resize event (SIGWINCH) occurs.

Reported by:	John Doe <rhamming2001_at_yahoo.com> and others on -stable.
Reviewed by:	dd
MFC after:	1 week


Also something else which I did not check on:


Revision 1.26: download - view: text, markup, annotated - select for diffs
Fri Aug 31 21:50:06 2001 UTC (7 years, 9 months ago) by mp
Branches: MAIN
Diff to: previous 1.25: preferred, colored
Changes since revision 1.25: +2 -1 lines

Exit gracefully when a SIGHUP is received. This prevents ee from going into
an infinite spin loop when the terminal window is forcibly blown away.

PR:		29553
Reported by:	Sung N. Cho <sucho2_at_vt.edu>
MFC after:	1 day


Thanks.  Let me know if I should do more to help.