Re: WITHOUT_MODULES, does it actually work?

On Nov 17, 2009, at 10:36 PM, Doug Barton wrote:

> Ben Kelly wrote:
>> On Nov 17, 2009, at 8:06 PM, Doug Barton wrote:
>> 
>>> Ben Kelly wrote:
>>>> It seems there are some left over bits then.  I have this in /usr/src/sys/modules/Makefile:
>>>> 
>>>> .for reject in ${WITHOUT_MODULES}
>>>> SUBDIR:= ${SUBDIR:N${reject}}
>>>> .endfor
>>> Well it seems my search was not exhaustive.
>>> 
>>> My recommendation then would be to file a src PR so that someone can
>>> look into it. :)
>> 
>> I've opened a doc PR for the bad example in the handbook and a conf PR for the patch to make WITHOUT_MODULES work from the kernel config file using makeoptions.  I haven't gotten PR numbers back from the system yet.
> 
> You can add to the mix the fact that options like modules_override and
> without_modules are documented in make.conf(5) instead of in
> src.conf(5) which is where (arguably) they should be.

From the log for r88893 of /usr/src/sys/conf/kern.pre.mk I think its intended that the module variables are related to ports in some way:

  Move initialization of the MKMODULESENV envorinoment to kern.pre.mk
  from kern.post.mk so port makefiles can augment it.

So I'm guessing make.conf might be the right place.

In any case, here are the PRs I opened:

    http://www.freebsd.org/cgi/query-pr.cgi?pr=140649
    http://www.freebsd.org/cgi/query-pr.cgi?pr=140650

Thanks.

- Ben