[Call for reviews] Support domain-search option in dhclient(8)

From: Jean-Sébastien Pédron <dumbbell_at_FreeBSD.org>
Date: Sat, 12 Nov 2011 17:07:03 +0100
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi!

Attached is a patch that adds support for "domain-search" option
(#119) as defined in RFC 3397[1]. This allows a DHCP server to publish
a list of domain names that should be used to search for non-fully
qualified domain names.

There's already a PR opened about this:
http://www.freebsd.org/cgi/query-pr.cgi?pr=151940

With this patch applied and a DHCP server configured to publish this
option, dhclient(8) will add a line similar to the following one:
  search example.org. foobar.com.

In the example, this indicates that the name "www" should be resolved
first as "www.example.org", then as "www.foobar.com".

I prepared a regression test to be added to tools/regression (not
included). However, I'm not knowledgeable enough to anticipate all
security-related issues. I would appreciate a review especially with
this in mind :)

Thank you!

[1] http://www.faqs.org/rfcs/rfc3397.html

- -- 
Jean-Sébastien Pédron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk6+macACgkQa+xGJsFYOlMRBACghVQ62JSyt8/yGOsV9jE661W/
PRoAoMsZnSYLfVSzCqZhxbukrbP4bI4q
=qEZg
-----END PGP SIGNATURE-----

Received on Sat Nov 12 2011 - 15:07:07 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:20 UTC